Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80239440
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -72,14 +74,12 @@ public MetricRegistry(Configuration config) {
}
this.scopeFormats = scopeFormats;
- char delim;
- try {
- delim =
config.getString(ConfigConstants.METRICS_SCOPE_DELIMITER, ".").charAt(0);
- } catch (Exception e) {
- LOG.warn("Failed to parse delimiter, using default
delimiter.", e);
- delim = '.';
+ String defaultDelimiter =
config.getString(ConfigConstants.METRICS_SCOPE_DELIMITER, ".");
+ if(defaultDelimiter.length()!=1){
--- End diff --
these changes are unnecessary, renaming ```delimiter``` to
```globalDelimiter``` should be sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
