SteNicholas commented on code in PR #311:
URL: https://github.com/apache/flink-table-store/pull/311#discussion_r993463151
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/compact/PartialUpdateMergeFunction.java:
##########
@@ -54,9 +53,15 @@ public void reset() {
@Override
public void add(KeyValue kv) {
- checkArgument(
- kv.valueKind() == RowKind.INSERT || kv.valueKind() ==
RowKind.UPDATE_AFTER,
- "Partial update can not accept delete records. Partial delete
is not supported!");
+ if (kv.valueKind() == RowKind.UPDATE_BEFORE || kv.valueKind() ==
RowKind.DELETE) {
Review Comment:
For the `RowKind.UPDATE_BEFORE`, just throws the exception and no need to
check whether to ignore the `RowKind.UPDATE_BEFORE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
