kristoffSC commented on code in PR #21022:
URL: https://github.com/apache/flink/pull/21022#discussion_r994347832
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/committables/CommittableCollectorSerializerTest.java:
##########
@@ -107,6 +109,29 @@ void testCommittableCollectorV2SerDe() throws IOException {
"Deserialized CommittableCollector", subtaskId,
numberOfSubtasks, copy);
}
+ @Test
+ void
testAlignSubtaskCommittableManagerCheckpointWithCheckpointCommittableManagerCheckpointId()
+ throws IOException {
+ // Create CommittableCollector holding a higher checkpointId than
+ // Sink.InitContext#INITIAL_CHECKPOINT_ID
+ final CommittableCollector<Integer> committableCollector =
Review Comment:
nit:
Probably will never happen, but what if
Sink.InitContext#INITIAL_CHECKPOINT_ID value would be changed in the future?
Maybe defining `checkpointId as Sink.InitContext#INITIAL_CHECKPOINT_ID + 1`
or something like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
