MartijnVisser commented on PR #21047: URL: https://github.com/apache/flink/pull/21047#issuecomment-1277688080
> last time I looked into it I found that they changed the data model and we should look at the ramifications of that first before bumping anything. They've made such a change in their 0.10 version: > [CHANGE] Switch data model to OpenMetrics. Primarily this means that _total if present is stripped from the metric name of counters, and _total is now always a suffix on the sample value. This means that all Counter samples now have a _total suffix (https://github.com/prometheus/client_java/pull/615) > [CHANGE] The io.prometheus.client.Collector.Type enum' value UNTYPED renamed to UNKNOWN (https://github.com/prometheus/client_java/pull/615) We should actually check if there are proper tests for this too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
