pnowojski commented on code in PR #21056:
URL: https://github.com/apache/flink/pull/21056#discussion_r995070741
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -148,6 +148,19 @@ public class ExecutionConfig implements Serializable,
Archiveable<ArchivedExecut
.defaultValue(-1)
.withDescription(
"Should no longer be used because it is subsumed
by RestartStrategyConfiguration");
+
+ /**
+ * Conceptually this is the same as {@link
PipelineOptions#GLOBAL_JOB_PARAMETERS}, but it's
+ * stored/serialized in the configuration very differently. Use with
care... First {@link
+ * PipelineOptions#GLOBAL_JOB_PARAMETERS} is read from the config,
converted into {@link
+ * MapBasedJobParameters} and then its stored in the {@link
#configuration} via {@link
+ * #GLOBAL_JOB_PARAMETERS_EXECUTION_CONFIG}. User can override this value
via {@link
+ * ExecutionConfig#setGlobalJobParameters(GlobalJobParameters)}.
+ */
+ public static final ConfigOption<GlobalJobParameters>
GLOBAL_JOB_PARAMETERS_EXECUTION_CONFIG =
+ key(PipelineOptions.GLOBAL_JOB_PARAMETERS.key())
+ .defaultValue(new GlobalJobParameters());
Review Comment:
Ok. E2e test failure shows that this won't work that easily. `ConfigOption`
doesn't support arbitrary types, so I would propose to store it as base64
serialised string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
