JingsongLi commented on code in PR #316:
URL: https://github.com/apache/flink-table-store/pull/316#discussion_r995436069
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java:
##########
@@ -422,25 +490,36 @@ private boolean tryCommitOnce(
previousChangesListName = manifestList.write(newMetas);
// write new changes into manifest files
- List<ManifestFileMeta> newChangesManifests =
manifestFile.write(changes);
+ List<ManifestFileMeta> newChangesManifests =
manifestFile.write(tableFiles);
newMetas.addAll(newChangesManifests);
newChangesListName = manifestList.write(newChangesManifests);
+ // write changelog into manifest files
+ changelogMetas.addAll(manifestFile.write(changelogFiles));
Review Comment:
Can we avoid generating redundant files without changelog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
