XComp commented on PR #20168: URL: https://github.com/apache/flink/pull/20168#issuecomment-1281823045
Thanks for your contribution @zhoulii. Just a minor comment about the timeouts: Keep in mind that we actually want to remove timeouts from JUnit tests (see [coding guidelines](https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests)) to benefit from the thread dump printout generated by our CI tools. So it might be better to remove them instead of migrating them to JUnit5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
