zhoulii commented on code in PR #20168:
URL: https://github.com/apache/flink/pull/20168#discussion_r997908191
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java:
##########
@@ -358,8 +370,9 @@ public void testBatchQueryExecution() throws Exception {
}
}
- @Test(timeout = 90_000L)
- public void testBatchQueryExecutionMultipleTimes() throws Exception {
+ @Test
+ @Timeout(90)
Review Comment:
As @XComp suggested:
> Keep in mind that we actually want to remove timeouts from JUnit tests
(see [coding
guidelines](https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests))
to benefit from the thread dump printout generated by our CI tools. So it
might be better to remove them instead of migrating them to JUnit5
We'd better remove timeouts instead of migrating them to JUnit5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
