dannycranmer commented on code in PR #20937:
URL: https://github.com/apache/flink/pull/20937#discussion_r998630251
##########
flink-connectors/flink-sql-connector-hive-3.1.3/pom.xml:
##########
@@ -164,11 +172,6 @@ under the License.
<pattern>org.apache.parquet</pattern>
<shadedPattern>org.apache.hive.shaded.parquet</shadedPattern>
</relocation>
- <!-- Guava
dependencies that still end up in the shaded JAR are relocated to avoid
clashes. -->
- <relocation>
-
<pattern>com.google</pattern>
-
<shadedPattern>org.apache.flink.hive.shaded.com.google</shadedPattern>
- </relocation>
Review Comment:
This is needed, I can now see we are including 2x versions of Guava into the
jar:
- The non-relocated version (com.google)
- The version coming from avro (avro.shaded)
```
unzip -l target/flink-sql-connector-hive-3.1.3_2.12-1.17-SNAPSHOT.jar | grep
/Futures.class
25448 10-18-2022 20:27 com/google/common/util/concurrent/Futures.class
19380 10-18-2022 20:27
avro/shaded/com/google/common/util/concurrent/Futures.class
```
##########
flink-connectors/flink-sql-connector-hive-3.1.3/src/main/resources/META-INF/NOTICE:
##########
@@ -0,0 +1,52 @@
+flink-sql-connector-hive-3.1.3
+Copyright 2014-2022 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the Apache Software
License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+- org.apache.avro:avro:1.8.2
+- org.apache.avro:avro-mapred:hadoop2:1.8.2
+- org.apache.hive:hive-exec:3.1.3
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
+
+- org.antlr:antlr-runtime:3.5.2
+
+The bundled Apache Hive org.apache.hive:hive-exec dependency bundles the
following dependencies under
+the Apache Software License 2.0
(http://www.apache.org/licenses/LICENSE-2.0.txt)
Review Comment:
We still do not have Guava in the NOTICE. Shall we jump on a call tomorrow
and discuss? I feel like we are not making progress. I will slack you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
