Samrat002 commented on code in PR #20937:
URL: https://github.com/apache/flink/pull/20937#discussion_r999173879


##########
flink-connectors/flink-sql-connector-hive-3.1.3/pom.xml:
##########
@@ -164,11 +172,6 @@ under the License.
                                                                        
<pattern>org.apache.parquet</pattern>
                                                                        
<shadedPattern>org.apache.hive.shaded.parquet</shadedPattern>
                                                                </relocation>
-                                                               <!-- Guava 
dependencies that still end up in the shaded JAR are relocated to avoid 
clashes. -->
-                                                               <relocation>
-                                                                       
<pattern>com.google</pattern>
-                                                                       
<shadedPattern>org.apache.flink.hive.shaded.com.google</shadedPattern>
-                                                               </relocation>

Review Comment:
   reverted the changes.
   
   
   
    ```
    unzip -l target/flink-sql-connector-hive-3.1.3_2.12-1.17-SNAPSHOT.jar | 
grep /Futures.class     
       31886  10-19-2022 14:36   
org/apache/flink/hive/shaded/com/google/common/util/concurrent/Futures.class
       19380  10-19-2022 14:36   
avro/shaded/com/google/common/util/concurrent/Futures.class
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to