czy006 commented on code in PR #21012:
URL: https://github.com/apache/flink/pull/21012#discussion_r1000065071
##########
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarHandlerParameterTest.java:
##########
@@ -211,6 +218,37 @@ void testProvideJobId() throws Exception {
assertThat(jobGraph.get().getJobID()).isEqualTo(jobId);
}
+ @Test
+ void testProvideFlinkConfig() throws Exception {
+
+ REQB jarRequestBodyWithFlinkConfig =
getJarRequestBodyWithFlinkConfig(FLINK_CONFIGURATION);
+ HandlerRequest<REQB> request =
+ createRequest(
+ getJarRequestBodyWithFlinkConfig(FLINK_CONFIGURATION),
+ getUnresolvedJarMessageParameters(),
+ getUnresolvedJarMessageParameters(),
+ jarWithManifest);
+
+ handleRequest(request);
+
+ Optional<JobGraph> jobGraph = getLastSubmittedJobGraphAndReset();
+
+ assertThat(jobGraph.isPresent()).isTrue();
+ JobGraph graph = jobGraph.get();
+
+ assertThat(getExecutionConfig(graph).getParallelism())
+ .isNotEqualTo(
+ Integer.valueOf(
+
FLINK_CONFIGURATION.get(CoreOptions.DEFAULT_PARALLELISM.key())));
+ if (jarRequestBodyWithFlinkConfig instanceof JarRunRequestBody) {
Review Comment:
Does that mean I should implement the part of the JobPlanHandler logic that
parses flinkconfig, or should I rewrite a separate test where I only test
JobRunPlanHandler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
