[
https://issues.apache.org/jira/browse/FLINK-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522590#comment-15522590
]
ASF GitHub Bot commented on FLINK-4673:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2545#discussion_r80439161
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/TypeExtractorTest.java
---
@@ -1857,12 +1856,6 @@ public void testEitherHierarchy() {
Assert.assertEquals(expected, ti);
}
- @Test(expected=InvalidTypesException.class)
- public void testEitherFromObjectException() {
- Either<String, Tuple1<Integer>> either = Either.Left("test");
- TypeExtractor.getForObject(either);
--- End diff --
This test is necessary. The exception is not thrown anymore but the type
information that is currently generated is invalid (the right type information
is `null`, which should never happen).
> TypeInfoFactory for Either type
> -------------------------------
>
> Key: FLINK-4673
> URL: https://issues.apache.org/jira/browse/FLINK-4673
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.2.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Minor
>
> I was able to resolve the requirement to specify an explicit
> {{TypeInformation}} in the pull request for FLINK-4624 by creating a
> {{TypeInfoFactory}} for the {{Either}} type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
