[ 
https://issues.apache.org/jira/browse/FLINK-29727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Fedulov updated FLINK-29727:
--------------------------------------
    Description: 
Currently {{docker-enterypoint.sh}} always overrides {{jobmanager.rpc.address}} 
in {{flink-conf.yaml}} either with an environment variable 
{{JOB_MANAGER_RPC_ADDRESS}} or with a {{hosname}} : 
[link|https://github.com/apache/flink-docker/blob/3c259f46231b97202925a111a8205193c15bbf78/1.15/scala_2.12-java8-ubuntu/docker-entrypoint.sh#L25]
 . This causes, for instance, jobmanager address configured in 
`FlinkContainers` that are based on an existing image (contains 
`docker-entrypoint.sh` in contrast to an image that is built on-the flight from 
flink-dist) to be overridden by the hostname. TMs then fail for connect to the 
JM. A workaround is to use {{TestContainersSettings}} to set 
{{JOB_MANAGER_RPC_ADDRESS }}, which is a suboptimal from the user perspective.

Configuration in flink-conf.yaml should instead be kept if 
JOB_MANAGER_RPC_ADDRESS is not passed explicitly and only overridden by the 
{{hostname}} if nothing was specified in the confit. 

  was:
Currently {{docker-enterypoint.sh}} always overrides {{jobmanager.rpc.address}} 
in {{flink-conf.yaml}} either with the environment variable 
{{JOB_MANAGER_RPC_ADDRESS}} or with a {{hosname}} : 
[link|https://github.com/apache/flink-docker/blob/3c259f46231b97202925a111a8205193c15bbf78/1.15/scala_2.12-java8-ubuntu/docker-entrypoint.sh#L25]
 . This causes, for instance, jobmanager address configured in 
`FlinkContainers` that are based on an existing image (contains 
`docker-entrypoint.sh` in contrast to an image that is built on-the flight from 
flink-dist) to be overridden by the hostname. TMs then fail for connect to the 
JM. A workaround is to use {{TestContainersSettings}} to set 
{{JOB_MANAGER_RPC_ADDRESS }}, which is a suboptimal from the user perspective.

Configuration in flink-conf.yaml should instead be kept if 
JOB_MANAGER_RPC_ADDRESS is not passed explicitly and only overridden by the 
{{hostname}} if nothing was specified in the confit. 


> Fall back to flink-conf.yaml if no JOB_MANAGER_RPC_ADDRESS is specified
> -----------------------------------------------------------------------
>
>                 Key: FLINK-29727
>                 URL: https://issues.apache.org/jira/browse/FLINK-29727
>             Project: Flink
>          Issue Type: Improvement
>          Components: flink-docker
>            Reporter: Alexander Fedulov
>            Assignee: Alexander Fedulov
>            Priority: Major
>
> Currently {{docker-enterypoint.sh}} always overrides 
> {{jobmanager.rpc.address}} in {{flink-conf.yaml}} either with an environment 
> variable {{JOB_MANAGER_RPC_ADDRESS}} or with a {{hosname}} : 
> [link|https://github.com/apache/flink-docker/blob/3c259f46231b97202925a111a8205193c15bbf78/1.15/scala_2.12-java8-ubuntu/docker-entrypoint.sh#L25]
>  . This causes, for instance, jobmanager address configured in 
> `FlinkContainers` that are based on an existing image (contains 
> `docker-entrypoint.sh` in contrast to an image that is built on-the flight 
> from flink-dist) to be overridden by the hostname. TMs then fail for connect 
> to the JM. A workaround is to use {{TestContainersSettings}} to set 
> {{JOB_MANAGER_RPC_ADDRESS }}, which is a suboptimal from the user perspective.
> Configuration in flink-conf.yaml should instead be kept if 
> JOB_MANAGER_RPC_ADDRESS is not passed explicitly and only overridden by the 
> {{hostname}} if nothing was specified in the confit. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to