XComp commented on code in PR #20805:
URL: https://github.com/apache/flink/pull/20805#discussion_r1001878855
##########
flink-test-utils-parent/flink-test-utils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnFailureTest.java:
##########
@@ -18,17 +18,16 @@
package org.apache.flink.testutils.junit;
-import org.apache.flink.testutils.junit.extensions.retry.RetryExtension;
-
-import org.junit.jupiter.api.AfterAll;
-import org.junit.jupiter.api.TestTemplate;
-import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.AfterClass;
+import org.junit.Rule;
+import org.junit.Test;
import static org.assertj.core.api.Assertions.assertThat;
-/** Tests for the RetryOnFailure annotation. */
-@ExtendWith(RetryExtension.class)
-class RetryOnFailureTest {
+/** Tests for the {@link RetryOnFailure} annotation on JUnit4 {@link
RetryRule}. */
+public class RetryOnFailureTest {
Review Comment:
@RyanSkraba sorry for reiterating over the PR again but could you also move
this change out into its own commit? Initially, that's what I wanted to do
myself. But I realized that I probably would overwrite your authorship.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
