xintongsong commented on code in PR #20910:
URL: https://github.com/apache/flink/pull/20910#discussion_r1002974667


##########
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendDynamicPropertiesTest.java:
##########
@@ -167,6 +170,27 @@ public void 
testDynamicPropertiesWithClientTimeoutAndDefaultParallelism() throws
                 configuration, args, cliUnderTest, expectedConfigValues);
     }
 
+    @Test
+    public void testSecurityConfigWithDynamicProperties() throws Exception {
+        String keytable = 
this.getClass().getResource("/keytable.file").getFile();

Review Comment:
   We can leverage the JUnit `@TempDir` feature here, rather than including an 
empty file in `resources/` (and then excluding it from the license check).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to