yunfengzhou-hub commented on code in PR #20454:
URL: https://github.com/apache/flink/pull/20454#discussion_r1003204433
##########
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java:
##########
@@ -397,12 +580,19 @@ public void abortCurrentTriggering() {
// we can remove the delegation once the checkpoint coordinator runs
fully in the
// scheduler's main thread executor
mainThreadExecutor.execute(
- () ->
- subtaskGatewayMap
- .values()
- .forEach(
- SubtaskGatewayImpl
-
::openGatewayAndUnmarkLastCheckpointIfAny));
+ () -> {
+ abortAcknowledgeCloseGatewayFutures(
Review Comment:
Yes. There is no guarantee from the documents that `abortCurrentTriggering`
must be invoked with `notifyCheckpointAborted`. From the source code of
`CheckpointCoordinator`, it can be found that if the checkpoint fails during
the initialization process, `abortCurrentTriggering` would be invoked while
`notifyCheckpointAborted` would not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
