RyanSkraba commented on code in PR #20267:
URL: https://github.com/apache/flink/pull/20267#discussion_r1003341622
##########
flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HdfsBehaviorTest.java:
##########
@@ -47,19 +43,17 @@ public class HdfsBehaviorTest extends
FileSystemBehaviorTestSuite {
// ------------------------------------------------------------------------
- @BeforeClass
- public static void verifyOS() {
- Assume.assumeTrue(
- "HDFS cluster cannot be started on Windows without
extensions.",
- !OperatingSystem.isWindows());
+ @BeforeAll
+ static void verifyOS() {
+ assumeThat(OperatingSystem.isWindows())
+ .describedAs("HDFS cluster cannot be started on Windows
without extensions.")
+ .isFalse();
}
- @BeforeClass
- public static void createHDFS() throws Exception {
- final File baseDir = TMP.newFolder();
-
+ @BeforeAll
+ static void createHDFS(@TempDir java.nio.file.Path tmp) throws Exception {
Review Comment:
I made this change because of the `getAbsolutePath`, but I'd argue that it's
strictly not necessary or desireable to avoid fully qualified classes! Most
uses of `@TempDir` are on `java.nio` classes I believe!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
