luoyuxia commented on code in PR #20830:
URL: https://github.com/apache/flink/pull/20830#discussion_r1003945031
##########
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/RunLengthDecoder.java:
##########
@@ -265,8 +265,16 @@ void readNextGroup() {
while (valueIndex < this.currentCount) {
// values are bit packed 8 at a time, so reading
bitWidth will always work
ByteBuffer buffer = in.slice(bitWidth);
- this.packer.unpack8Values(
- buffer, buffer.position(), this.currentBuffer,
valueIndex);
+ if (buffer.hasArray()) {
+ this.packer.unpack8Values(
Review Comment:
Could you please add some comments in here to expain why we change it?
Now, we use a deprecated method, we may need some comments for it so that
the others can know the context when come to this method for the case that the
method is deleted by a higher parquet version in some days and flink needs to
upgrad to the higher parquet version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
