mas-chen commented on code in PR #20475:
URL: https://github.com/apache/flink/pull/20475#discussion_r1004087843


##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java:
##########
@@ -398,6 +407,11 @@ private void registerMetricSync() {
                 });
     }
 
+    private String createProducerClientId(Properties props, int subtaskId) {
+        String prefix = 
props.getProperty(KafkaSinkOptions.CLIENT_ID_PREFIX.key());
+        return prefix + "-" + subtaskId;

Review Comment:
   It might not be easy to access that since the committer is a global 
singleton, so you wouldn't run into the need to distinguish between subtask ids



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to