LadyForest commented on code in PR #330:
URL: https://github.com/apache/flink-table-store/pull/330#discussion_r1004131903
##########
flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkScan.java:
##########
@@ -128,13 +124,13 @@ public boolean equals(Object o) {
}
SparkScan that = (SparkScan) o;
- return table.location().equals(that.table.location())
+ return table.name().equals(that.table.name())
Review Comment:
Is it safe to just compare table's name? What about two tables with the same
name and schema but under different namespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
