pvary opened a new pull request, #21148:
URL: https://github.com/apache/flink/pull/21148
## What is the purpose of the change
Make sure that `HadoopConfigLoader` considers every Hadoop configuration
which are set.
## Brief change log
* Changed `HadoopConfigLoader` to use `HadoopUtils.getHadoopConfiguration`
instead of just creating a new `Configuration` object
* Created a new unit test for the case:
`HadoopS3FileSystemTest.testConfigKeysFromHadoopConfig`
* Refactored the config file generating test utils from
`HadoopConfigLoadingTest` to `ConfigurationFileUtil.java`, and reused them in
the new test
* Added `hadoop-hdfs-client` test dependency to `flink-s3-fs-hadoop` project
- **This is something which should be checked by more experienced Flink
developers**
## Verifying this change
This change added tests and can be verified as follows:
* Added a new unit test for the case:
`HadoopS3FileSystemTest.testConfigKeysFromHadoopConfig` which reads the files
and check the priority of the configs
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **yes**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **yes** - checkpointing
will use the provided Hadoop configurations as well
- The S3 file system connector: yes - but only the configuration loading
## Documentation
- Does this pull request introduce a new feature? no - I think this is a
bug
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
