[
https://issues.apache.org/jira/browse/FLINK-29557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623665#comment-17623665
]
Aitozi edited comment on FLINK-29557 at 10/25/22 8:39 AM:
----------------------------------------------------------
I make a solution to add a common interface {{SinkFunctionOperator}} in the
{{flink-streaming-java}} module and let the {{SinkOperator}} and {{StreamSink}}
extends from it. So that we can check for the
{{SinkFunctionOperator#sinkFunction}} in the {{SimpleOperatorFactory}}
directly. what do you think [~gaoyunhaii] ?
was (Author: aitozi):
I make a solution to add a common interface {{SinkFunctionOperator}} in the
{{flink-streaming-java}} module and let the {{SinkOperator}} and {{StreamSink}}
extends from it. So that we can check for the
{{SinkFunctionOperator#sinkFunction}} in the {{SimpleOperatorFactory}}
directly. what do you think ?
> The SinkOperator's OutputFormat function is not recognized
> ----------------------------------------------------------
>
> Key: FLINK-29557
> URL: https://issues.apache.org/jira/browse/FLINK-29557
> Project: Flink
> Issue Type: Bug
> Components: API / Core, Table SQL / API
> Reporter: Aitozi
> Priority: Major
>
> In the {{SimpleOperatorFactory#of}}, only {{StreamSink}} is handled to
> register as {{SimpleOutputFormatOperatorFactory}}. So it will lost the output
> format information in {{SinkOperator}}. Then some hook functions like
> {{FinalizeOnMaster}} will have no chance to be executed.
> Due to the {{SinkOperator}} is in the table module, it can't be reached
> directly in the {{flink-streaming-java}}. So maybe we need introduce an extra
> common class eg: {{SinkFunctionOperator}} to describe the {{Sink}} operator
> and handle it individually.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
