gaborgsomogyi commented on code in PR #21160:
URL: https://github.com/apache/flink/pull/21160#discussion_r1005425742


##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java:
##########
@@ -69,71 +60,34 @@ public void install() throws SecurityInstallException {
         UserGroupInformation loginUser;
 
         try {
-            if (UserGroupInformation.isSecurityEnabled()
-                    && !StringUtils.isBlank(securityConfig.getKeytab())
-                    && !StringUtils.isBlank(securityConfig.getPrincipal())) {
-                String keytabPath = (new 
File(securityConfig.getKeytab())).getAbsolutePath();
-
-                
UserGroupInformation.loginUserFromKeytab(securityConfig.getPrincipal(), 
keytabPath);

Review Comment:
   @steveloughran since you have quite some XP w/ UGI a quick question:
   AFAIK `UserGroupInformation.loginUserFromKeytab` does the same just like
   ```
   ugi = UserGroupInformation.loginUserFromKeytabAndReturnUGI
   UserGroupInformation.setLoginUser(ugi);
   ```
   right?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to