snuyanzin commented on PR #19897:
URL: https://github.com/apache/flink/pull/19897#issuecomment-1291851895

   thanks for addressing comments
   I noticed that there is a bunch of classes still relying on junit4
   `org.apache.flink.formats.csv.CsvFileCompactionITCase`
   `org.apache.flink.formats.csv.CsvFilesystemBatchITCase`
   `org.apache.flink.formats.csv.CsvFilesystemStreamITCase`
   `org.apache.flink.formats.csv.CsvFilesystemStreamSinkITCase`
   because they depend on classes/hierarchies from other modules ...
   
   I wonder if in this case there should be a dedicated follow up task created 
to fix that...
   Because currently we can not say that flink-csv is moved to junit5...
   WDYT?
   
   Also cc @XComp may be you have some clue about that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to