snuyanzin commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1005571712
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java:
##########
@@ -79,7 +79,8 @@
*/
@SuppressWarnings("serial")
@RetryOnFailure(times = 3)
Review Comment:
In javadoc[1] for `RetryOnFailure` is stated that
> \* <p>Add the {@link RetryRule} to your test class and annotate the class
and/or tests with {@link
> \* RetryOnFailure}.
which means it makes sense to use it only with junit4. With junit5 there
should be used `RetryOnException`
[1]
https://github.com/apache/flink/blob/f8c6a668cd2b887f33a0cf4608de2d6b95c71f03/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/RetryOnFailure.java#L30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
