snuyanzin commented on code in PR #19897:
URL: https://github.com/apache/flink/pull/19897#discussion_r1006642754
##########
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatFilesystemStatisticsReportTest.java:
##########
@@ -34,16 +34,16 @@
/**
* Test for statistics functionality in {@link CsvFormatFactory} in the case
of file system source.
*/
-public class CsvFormatFilesystemStatisticsReportTest extends
CsvFormatStatisticsReportTest {
+class CsvFormatFilesystemStatisticsReportTest extends
CsvFormatStatisticsReportTest {
+ @Override
@BeforeEach
public void setup(@TempDir File file) throws Exception {
Review Comment:
nit: since the hierarchy is in different packages package private does not
work here however probably it should either changed to `protected` for the
whole hierarchy or marked like `@VisibleForTestting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
