[
https://issues.apache.org/jira/browse/FLINK-28863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625402#comment-17625402
]
Jinzhong Li commented on FLINK-28863:
-------------------------------------
In my opinion, for Rocksdb native savepoint SnapshotResult, we should put
[sstFiles|https://github.com/apache/flink/blob/bb9f2525e6e16d00ef2f0739d9cb96c2e47e35e7/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java#L302]
into privateState Map of IncrementalRemoteKeyedStateHandle to fix this issue.
This change has no effect on restore, which [downloads both the priavateStates
and
shareStates|[https://github.com/apache/flink/blob/35c5f674041bcefea93e1de459cea0d1789f98e0/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java#L53].]
[~yunta] WDYT? If my understanding is correct, I can fix the issue.
> Snapshot result of RocksDB native savepoint should have empty shared-state
> --------------------------------------------------------------------------
>
> Key: FLINK-28863
> URL: https://issues.apache.org/jira/browse/FLINK-28863
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing, Runtime / State Backends
> Reporter: Yun Tang
> Priority: Major
> Fix For: 1.17.0, 1.15.3, 1.16.1
>
>
> The current snapshot result of RocksDB native savepoint has non-empty shared
> state, which is obviously not correct as all snapshot artifacts already stay
> in the exclusive checkpoint scope folder.
> This does not bring real harmful result due to we would not register the
> snapshot results of RocksDB native savepoint.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
