XComp commented on PR #21137:
URL: https://github.com/apache/flink/pull/21137#issuecomment-1296841251

   > @XComp I totally agree that we should also check the other LeaderContender 
to ensure they are not suffer from this. However, from my point of view, in 
consideration of limiting the scope of this pull request, I suggest that only 
the JobMasterServiceLeadershipRunner be tested in this PR. For other 
LeaderContender, I will open a separate ticket for tracking. WDYT?
   
   Yup, I agree. Creating follow-up Jira issues makes sense.
   
   > 
testJobMasterServiceLeadershipRunnerCloseWhenElectionServiceGrantLeaderShip 
separately, the probability of deadlock will be greatly increased. I don't have 
a deep understanding of Junit's testing framework, so I don't know why there is 
such a difference. Maybe you can try to run the entire test class directly to 
help you reproduce the problem.
   
   Thanks for the hint. :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to