Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2369#discussion_r80629176
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.java
 ---
    @@ -102,11 +102,11 @@
         * @param serializationSchema User defined (keyless) serialization 
schema.
         * @param producerConfig Properties with the producer configuration.
         */
    -   public static <T> FlinkKafkaProducer010Configuration 
writeToKafka(DataStream<T> inStream,
    -                                                                           
String topicId,
    -                                                                           
SerializationSchema<T> serializationSchema,
    -                                                                           
Properties producerConfig) {
    -           return writeToKafka(inStream, topicId, new 
KeyedSerializationSchemaWrapper<>(serializationSchema), producerConfig, new 
FixedPartitioner<T>());
    +   public static <T> FlinkKafkaProducer010Configuration 
writeToKafkaWithTimestamps(DataStream<T> inStream,
    --- End diff --
    
    Add the generic type parameter `T` to `FlinkKafkaProducer010Configuration` 
here too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to