snuyanzin opened a new pull request, #21221: URL: https://github.com/apache/flink/pull/21221
## What is the purpose of the change The PR upgrades ArchUnit to 1.0.0 There are some breaking changes mentioned at [1] and [2] especially ``` The ArchUnit types Function, Predicate and Optional have been replaced by the JDK 8 equivalents DescribedPredicate now extends the JDK 8 Predicate, so apply(..) has to be replaced by test(..) As mentioned in Enhancements/Core ArchRules will now by default reject evaluating if the set passed to the should-clause is empty. This will break existing rules that don't check any elements in their should-clause. You can restore the old behavior by setting the ArchUnit property archRule.failOnEmptyShould=false ``` for the latest one in 0.23.1 there was added an option allowing making it per rule[3]. In Flink it impacts `INTEGRATION_TEST_ENDING_WITH_ITCASE` rule since not in every module there are inheritors from `AbstractTestBase` [1] https://github.com/TNG/ArchUnit/releases/tag/v1.0.0-rc1 [2] https://github.com/TNG/ArchUnit/releases/tag/v0.23.0 [3] https://github.com/TNG/ArchUnit/releases/tag/v0.23.1 ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes ) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no) - The serializers: ( no) - The runtime per-record code paths (performance sensitive): ( no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no) - The S3 file system connector: ( no) ## Documentation - Does this pull request introduce a new feature? ( no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
