zentol commented on code in PR #21227:
URL: https://github.com/apache/flink/pull/21227#discussion_r1012608382
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rest/compatibility/CompatibilityRoutines.java:
##########
@@ -230,6 +230,7 @@ private static void assertCompatible(final JsonNode old,
final JsonNode cur) {
final JsonNode curProperties = curProperty.get("properties");
if (oldProperties != null) {
+ assertThat(curProperties).as("New object has no
properties.").isNotNull();
Review Comment:
This was necessary because the compatibility checks run in both directions,
and we never accounted for the possibility of an endpoint returning `object` at
one point and then switching to `any`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
