huwh opened a new pull request, #21233:
URL: https://github.com/apache/flink/pull/21233
## What is the purpose of the change
SlotManager determines whether a resource can be allocated by the return
value of ResourceActions.allocateResource. It can reduce unnecessary waiting by
quickly marking the slotRequest as a failure if the resource cannot be
allocated.
The new declareResourceNeed function will not return whether resources could
be allocated. This will cause useless waiting for SlotRequests.
This PR will split ResourceNotEnoughNotifier from ResourceActions so that we
can make ResourceActions only co-works with ActiveResourceManager. And
SlotManager cloud determine whether can allocate new resources by
ResourceActions is null or not.
## Brief change log
- Extract the notifyNotEnoughResourcesAvailable function from
ResourceActions to ResourceNotEnoughNotifier
- Move ResourceActionsImpl from ResourceManager to ActiveResourceManager
- SlotManager determines whether a resource can be allocated by whether the
ResourceActions is null or not.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes, ResourceManager)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
* part of
https://docs.google.com/document/d/1lcmf3MKmcmf9tsPc1whaZHMYKurGoGtqOXEep9ngP2k/edit#
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
