[ 
https://issues.apache.org/jira/browse/FLINK-29872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628605#comment-17628605
 ] 

Chesnay Schepler commented on FLINK-29872:
------------------------------------------

Can you expand on why you consider generating a client to be complicated?
Generating one for each Flink version, sure; but generating on for the 1.15 
spec and using that going forward shouldn't be hard?
You'd also further decouple the operator from the actual Flink codebase (and 
certain modules/dependencies?), which should be a long-term goal anyway.
(additionally you wouldn't have to wait for a Flink release to benefit from 
changes to the spec)

You're probably gonna argue that you'd like to use 1.16+ features of the REST 
API; however you could probably even use a client generated from the 1.16 spec. 
Because we aren't actually marking fields as required in there a generated 
client _should_ treat everything as optional, exactly as you propose.

I really don't get what the big deal is supposed to be.


> JobDetailsInfo Rest endpoint breaking change in 1.16
> ----------------------------------------------------
>
>                 Key: FLINK-29872
>                 URL: https://issues.apache.org/jira/browse/FLINK-29872
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / REST
>    Affects Versions: 1.16.0
>            Reporter: Gyula Fora
>            Priority: Major
>
> Flink 1.16 introduces a breaking change to the JobDetailsInfo endpoints by 
> adding 3 required fields to: 
> [https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/metrics/IOMetricsInfo.java]
> accumulatedBackpressured, accumulatedIdle, accumulatedBusy fields should not 
> be primitive (which makes them required) but instead nullable.
> This would allow the 1.16 restclient to read the jobdetails of previous 
> cluster versions



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to