JingGe commented on code in PR #21219:
URL: https://github.com/apache/flink/pull/21219#discussion_r1013714868
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java:
##########
@@ -449,6 +456,34 @@ protected
FlinkFilterIntoJoinRule(FlinkFilterIntoJoinRule.Config config) {
super(config);
}
+ @Override
+ public boolean matches(RelOptRuleCall call) {
+ Join join = call.rel(1);
+ boolean existTemporalJoinCondition =
existTemporalJoinCondition(join.getCondition());
+ return !existTemporalJoinCondition && super.matches(call);
+ }
+
+ private boolean existTemporalJoinCondition(RexNode joinCondition) {
Review Comment:
NIT: I would suggest replacing the naming of `existTemporalJoinCondition`
with `isEventTimeTemoralJoin` (or `isNotEventTimeTemoralJoin`) to improve the
code readability. The return on line number 463 could become:
`return !isEventTimeTemoralJoin && super.matches(call);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
