pnowojski commented on code in PR #21201:
URL: https://github.com/apache/flink/pull/21201#discussion_r1013753790
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimersSnapshotReaderWriters.java:
##########
@@ -223,10 +167,10 @@ public static <K, N> InternalTimersSnapshotReader<K, N>
getReaderForVersion(
switch (version) {
case NO_VERSION:
- return new
InternalTimersSnapshotReaderPreVersioned<>(userCodeClassLoader);
-
case 1:
- return new
InternalTimersSnapshotReaderV1<>(userCodeClassLoader);
+ throw new UnsupportedOperationException(
Review Comment:
I will keep it as it is. The default branch is an illegal state, as if it's
triggered that's a bug in the code. Someone forgot to implement something. This
branch is just not supported (and will never be), but that's a different
message to "encountered illegal state".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
