XComp commented on code in PR #20230:
URL: https://github.com/apache/flink/pull/20230#discussion_r1014228413
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java:
##########
@@ -126,7 +126,7 @@ class ParquetColumnarRowInputFormatTest {
new MapType(new IntType(), new BooleanType()),
RowType.of(new VarCharType(VarCharType.MAX_LENGTH), new
IntType()));
- @TempDir private java.io.File folder;
Review Comment:
Yes, it should be changed because you're introducing a code change in this
PR that you fix in the very same PR but a separate commit. This generates
unnecessary diffs. But admittedly, we can just squash the two commits into one,
anyway. So, I'm gonna go ahead with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
