[
https://issues.apache.org/jira/browse/FLINK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526621#comment-15526621
]
ASF GitHub Bot commented on FLINK-4669:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2541#discussion_r80730795
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
---
@@ -124,7 +125,7 @@ class StreamExecutionEnvironment(javaEnv: JavaEnv) {
* Gets the checkpoint config, which defines values like checkpoint
interval, delay between
* checkpoints, etc.
*/
- def getCheckpointConfig = javaEnv.getCheckpointConfig()
--- End diff --
Calling Java methods with parenthesis or without actually somewhat subject
to debate.
For Scala methods, the writer decides whether it is a method with or
without parenthesis.
For Java, the caller can only "guess" what the method does (is returning a
mutable field considered a side effect?), so in most places we call Java
methods as Java methods.
> scala api createLocalEnvironment() function add default Configuration
> parameter
> -------------------------------------------------------------------------------
>
> Key: FLINK-4669
> URL: https://issues.apache.org/jira/browse/FLINK-4669
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Reporter: shijinkui
>
> scala program can't direct use createLocalEnvironment with custom Configure
> object.
> such as I want to start web server in local mode, I will do such as:
> ```
> // set up execution environment
> val conf = new Configuration
> conf.setBoolean(ConfigConstants.LOCAL_START_WEBSERVER, true)
> conf.setInteger(ConfigConstants.JOB_MANAGER_WEB_PORT_KEY,
> ConfigConstants.DEFAULT_JOB_MANAGER_WEB_FRONTEND_PORT)
> val env = new org.apache.flink.streaming.api.scala.StreamExecutionEnvironment(
>
> org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.createLocalEnvironment(2,
> conf)
> )
> ```
> so we need createLocalEnvironment function have a config parameter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
