vahmed-hamdy commented on code in PR #21224:
URL: https://github.com/apache/flink/pull/21224#discussion_r1014607586
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java:
##########
@@ -503,6 +503,10 @@ private void
initializeState(Collection<BufferedRequestState<RequestEntryT>> sta
for (BufferedRequestState<RequestEntryT> state : states) {
initializeState(state);
}
+
+ if (bufferedRequestEntries.size() > 0 && !existsActiveTimerCallback) {
+ registerCallback();
+ }
}
Review Comment:
Thanks @dannycranmer , I totally agree we have some duplicate logic between
them methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
