hlteoh37 commented on code in PR #13: URL: https://github.com/apache/flink-connector-aws/pull/13#discussion_r1014660260
########## flink-sql-connector-dynamodb/src/main/resources/META-INF/NOTICE: ########## @@ -0,0 +1,48 @@ +flink-sql-connector-dynamodb + +Copyright 2014-2022 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- software.amazon.awssdk:dynamodb:2.17.247 +- software.amazon.awssdk:aws-json-protocol:2.17.247 +- software.amazon.awssdk:protocol-core:2.17.247 +- software.amazon.awssdk:profiles:2.17.247 +- software.amazon.awssdk:sdk-core:2.17.247 +- software.amazon.awssdk:auth:2.17.247 +- software.amazon.awssdk:http-client-spi:2.17.247 +- software.amazon.awssdk:regions:2.17.247 +- software.amazon.awssdk:annotations:2.17.247 +- software.amazon.awssdk:utils:2.17.247 +- software.amazon.awssdk:aws-core:2.17.247 +- software.amazon.awssdk:metrics-spi:2.17.247 +- software.amazon.awssdk:apache-client:2.17.247 +- software.amazon.awssdk:netty-nio-client:2.17.247 +- software.amazon.awssdk:sts:2.17.247 +- software.amazon.awssdk:aws-query-protocol:2.17.247 +- software.amazon.awssdk:json-utils:2.17.247 +- software.amazon.awssdk:third-party-jackson-core:2.17.247 +- io.netty:netty-codec-http:4.1.70.Final +- io.netty:netty-codec-http2:4.1.70.Final +- io.netty:netty-codec:4.1.70.Final +- io.netty:netty-transport:4.1.70.Final +- io.netty:netty-resolver:4.1.70.Final +- io.netty:netty-common:4.1.70.Final +- io.netty:netty-buffer:4.1.70.Final +- io.netty:netty-handler:4.1.70.Final +- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.70.Final +- io.netty:netty-transport-native-unix-common:4.1.70.Final +- io.netty:netty-transport-classes-epoll:4.1.70.Final +- com.typesafe.netty:netty-reactive-streams-http:2.0.5 +- com.typesafe.netty:netty-reactive-streams:2.0.5 Review Comment: QQ: I don't see these in my output as well. Is this expected? ########## flink-sql-connector-dynamodb/src/main/resources/META-INF/NOTICE: ########## @@ -0,0 +1,48 @@ +flink-sql-connector-dynamodb + +Copyright 2014-2022 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) + +- software.amazon.awssdk:dynamodb:2.17.247 +- software.amazon.awssdk:aws-json-protocol:2.17.247 +- software.amazon.awssdk:protocol-core:2.17.247 +- software.amazon.awssdk:profiles:2.17.247 +- software.amazon.awssdk:sdk-core:2.17.247 +- software.amazon.awssdk:auth:2.17.247 +- software.amazon.awssdk:http-client-spi:2.17.247 +- software.amazon.awssdk:regions:2.17.247 +- software.amazon.awssdk:annotations:2.17.247 +- software.amazon.awssdk:utils:2.17.247 +- software.amazon.awssdk:aws-core:2.17.247 +- software.amazon.awssdk:metrics-spi:2.17.247 +- software.amazon.awssdk:apache-client:2.17.247 +- software.amazon.awssdk:netty-nio-client:2.17.247 +- software.amazon.awssdk:sts:2.17.247 +- software.amazon.awssdk:aws-query-protocol:2.17.247 +- software.amazon.awssdk:json-utils:2.17.247 +- software.amazon.awssdk:third-party-jackson-core:2.17.247 +- io.netty:netty-codec-http:4.1.70.Final +- io.netty:netty-codec-http2:4.1.70.Final +- io.netty:netty-codec:4.1.70.Final +- io.netty:netty-transport:4.1.70.Final +- io.netty:netty-resolver:4.1.70.Final +- io.netty:netty-common:4.1.70.Final +- io.netty:netty-buffer:4.1.70.Final +- io.netty:netty-handler:4.1.70.Final +- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.70.Final Review Comment: Q: why do we have `linux-x86_64` here? I don't see it in the output of `maven-shade-plugin` ``` [INFO] Including io.netty:netty-transport-classes-epoll:jar:4.1.70.Final in the shaded jar. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
