XComp commented on code in PR #21247:
URL: https://github.com/apache/flink/pull/21247#discussion_r1015250934
##########
flink-end-to-end-tests/flink-sql-client-test/src/test/java/SqlClientITCase.java:
##########
@@ -261,8 +262,20 @@ private void sendMessages(String topic, String...
messages) {
props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG,
KAFKA.getBootstrapServers());
props.put(ProducerConfig.ACKS_CONFIG, "all");
+ int numPartitions = 1;
+ short replicationFactor = 1;
Review Comment:
```suggestion
final int numPartitions = 1;
final short replicationFactor = 1;
```
##########
flink-end-to-end-tests/flink-sql-client-test/src/test/java/SqlClientITCase.java:
##########
@@ -261,8 +262,20 @@ private void sendMessages(String topic, String...
messages) {
props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG,
KAFKA.getBootstrapServers());
props.put(ProducerConfig.ACKS_CONFIG, "all");
+ int numPartitions = 1;
+ short replicationFactor = 1;
Review Comment:
```suggestion
final int numPartitions = 1;
final short replicationFactor = 1;
```
nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
