pnowojski commented on code in PR #21245:
URL: https://github.com/apache/flink/pull/21245#discussion_r1015406636
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java:
##########
@@ -186,7 +164,7 @@ public void disableCheckpointing() {
* @return True if checkpointing is enables, false otherwise.
*/
public boolean isCheckpointingEnabled() {
- return checkpointInterval > 0;
+ return
configuration.contains(ExecutionCheckpointingOptions.CHECKPOINTING_INTERVAL);
Review Comment:
Yes, and I'm -1 for adding an extra `ConfigOption` that would only confuse
users, break compatibility and allow for inconsistencies:
- what if user modifies only `checkpoint.enabled` but doesn't set the
interval by mistake?
- what if user does the opposite?
If anything, I would be ok with a more fancy single property that allows
`manual`, `disabled` or `int` for the interval, but that would be quite a bit
of work that's IMO not worth it. `Long.MAX_VALUE` for those two power users
that will want to to manually trigger checkpoints is perfectly fine for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
