[
https://issues.apache.org/jira/browse/FLINK-27995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630362#comment-17630362
]
Sergey Nuyanzin edited comment on FLINK-27995 at 11/8/22 11:38 AM:
-------------------------------------------------------------------
I will put this comment since working with update of Calcite to 1.28.0 I had to
think about update of Janino since Calcite 1.28.0 depends on 3.1.6.
There are several issues on Janino side which should be kept in mind
# There are several issues with code compiliations introduced in 3.1.3 leading
to failure of Flink tests in {{AggregateITCase}} and {{OverAggregateITCase}}.
They are fixed in 3.1.7 and 3.1.8.
# Since 3.1.3 Janino is unable to compile code with variable initialized in
{{while}} condition (required by some Flink tests), link to the issue
https://github.com/janino-compiler/janino/issues/185 (fixed in master)
# Since 3.1.3 Janino is unable to compile code with variables initialized in
one {{if/else}} branches (required by lots of Flink tests), link to the issue
https://github.com/janino-compiler/janino/issues/187 (fixed in master)
# Since 3.1.3 Janino is unable to compile code with ternary operator where the
first branch is {{null}} without casting (required by some Flink tests), link
to the issue https://github.com/janino-compiler/janino/issues/188 (not fixed
yet)
Meanwhile each of this issues could be workarounded like declaration variables
with initialisation to some default value and adding explicit cast. In that
case Flink tests are passing (still discussable what is better wait for
Janino's release with all the fixes or not).
was (Author: sergey nuyanzin):
I will put this comment since working with update of Calcite to 1.28.0 I had to
think about update of Janino since Calcite 1.28.0 depends on 3.1.6.
There are several issues on Janino side which should be kept in mind
# There are several issues with code compiliations introduced in 3.1.3 leading
to failure of Flink tests in {{AggregateITCase}} and {{OverAggregateITCase}}.
They are fixed in 3.1.7 and 3.1.8.
# Since 3.1.3 Janino is unable to compile code with variable initialized in
{{while}} condition (required by some Flink tests), link to the issue
https://github.com/janino-compiler/janino/issues/185 (fixed in master)
# Since 3.1.3 Janino is unable to compile code with variables initialized in
one {{if/else}} branches (required by lots of Flink tests), link to the issue
https://github.com/janino-compiler/janino/issues/187 (fixed in master)
# Since 3.1.3 Janino is unable to compile code with ternary operator where the
first branch is {{null}} without casting (required by some Flink tests), link
to the issue https://github.com/janino-compiler/janino/issues/188 (not fixed
yet)
Meanwhile each of this issues could be workarounded (still discussable what is
better wait for Janino's release with all the fixes or not).
> Upgrade Janino version
> -----------------------
>
> Key: FLINK-27995
> URL: https://issues.apache.org/jira/browse/FLINK-27995
> Project: Flink
> Issue Type: Technical Debt
> Components: Table SQL / Runtime
> Affects Versions: 1.16.0
> Reporter: Shengkai Fang
> Priority: Major
>
> Currently, the Janino version doesn't support JDK11 well.
>
> [https://lists.apache.org/thread/q052xdn1mnhjm9k4ojjjz22dk4r1xwfz]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
