fsk119 commented on code in PR #21229:
URL: https://github.com/apache/flink/pull/21229#discussion_r1017475905
##########
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/endpoint/hive/HiveServer2EndpointITCase.java:
##########
@@ -595,6 +598,27 @@ public void testGetInfo() throws Exception {
}
}
+ @Test
+ public void testUnrecognizedGetInfoTypeWontCauseFailure() throws Exception
{
Review Comment:
`testUnrecognizedGetInfoTypeWontCauseFailure` -> `testUnknownGetInfoType`
##########
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/endpoint/hive/HiveServer2EndpointITCase.java:
##########
@@ -595,6 +598,27 @@ public void testGetInfo() throws Exception {
}
}
+ @Test
+ public void testUnrecognizedGetInfoTypeWontCauseFailure() throws Exception
{
+ // When 'TGetInfoResp' is used and 'TGetInfoResp.infoValue' isn't set,
hive service will
+ // close connection. Here using new 'TGetInfoType' CLI_ODBC_KEYWORDS
added in hive3 sent by
+ // 'getSQLKeywords' to test whether it is handled appropriately.
+ Assumptions.assumeTrue(HiveVersionTestUtil.HIVE_310_OR_LATER);
+ try (Connection connection = ENDPOINT_EXTENSION.getConnection()) {
Review Comment:
I think it's better to use Thrift Client to send GetInfoRequest directly and
we can also test in Hive2 environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
