zentol commented on code in PR #21271:
URL: https://github.com/apache/flink/pull/21271#discussion_r1017970462
##########
docs/setup_docs.sh:
##########
@@ -35,9 +35,23 @@ echo "Created temporary file" $goModFileLocation/go.mod
# Make Hugo retrieve modules which are used for externally hosted documentation
currentBranch=$(git rev-parse --abbrev-ref HEAD)
+function integrate_connector_docs {
+ connector=$1
+ ref=$2
+ git clone --single-branch --branch ${ref}
https://github.com/apache/flink-connector-${connector}
+ theme_dir="../themes/connectors"
+ mkdir -p "${theme_dir}"
+ rsync -a flink-connector-${connector}/docs/content* "${theme_dir}/"
+}
+
if [[ ! "$currentBranch" =~ ^release- ]] || [[ -z "$currentBranch" ]]; then
- # If the current branch is master or not provided, get the documentation
from the main branch
Review Comment:
I'm wondering if we cant just remove the conditions.
AFAICT we don't need them; each release will have an explicit list of
integrated connector docs and versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
