syhily commented on code in PR #21252:
URL: https://github.com/apache/flink/pull/21252#discussion_r1019822514
##########
flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/runtime/PulsarRuntimeOperator.java:
##########
@@ -180,6 +180,10 @@ public void createTopic(String topic, int
numberOfPartitions) {
}
}
+ public void createSchema(String topic, Schema<?> schema) {
+ sneakyAdmin(() -> admin().schemas().createSchema(topic,
schema.getSchemaInfo()));
Review Comment:
These checked exceptions should be handled in some situation. But I `sneaky`
them just because of the poor design in Pulsar API. We can leave it here and
work through all the code to see which `sneaky` should be better removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
