zentol commented on code in PR #21296:
URL: https://github.com/apache/flink/pull/21296#discussion_r1020105044
##########
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/reporter/InstantiateViaFactory.java:
##########
@@ -26,14 +26,7 @@
import java.lang.annotation.Target;
/**
- * Annotation for {@link MetricReporter MetricReporters} that support
factories but want to maintain
- * backwards-compatibility with existing reflection-based configurations.
- *
- * <p>When an annotated reporter is configured to be used via reflection the
given factory will be
- * used instead.
- *
- * <p>Attention: This annotation does not work if the reporter is loaded as a
plugin. For these
- * cases, annotate the factory with {@link
InterceptInstantiationViaReflection} instead.
+ * This annotation has no effect and is only kept for compatibility reasons.
Review Comment:
We are keeping these around because reporters/factories that used them were
already set up correctly to at least support factories (else there's no reason
to use these annotations!).
I didn't want to break these reporters, when really only the configuration
should be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
