Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2559#discussion_r80909904
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
@@ -285,7 +293,14 @@ public void
commitSpecificOffsetsToKafka(Map<KafkaTopicPartition, Long> offsets)
if (this.consumer != null) {
synchronized (consumerLock) {
- this.consumer.commitSync(offsetsToCommit);
+ if (!commitInProgress) {
+ commitInProgress = true;
+
this.consumer.commitAsync(offsetsToCommit, offsetCommitCallback);
+ }
+ else {
+ LOG.warn("Committing previous
checkpoint's offsets to Kafka not completed. " +
--- End diff --
Possibly yes. But on the other hand, this should be pretty visible if it
happens.
I would expect that with proper options to participate in group checkpoint
committing, most Flink jobs run without committing to Kafka/ZooKeeper.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
