mbalassi commented on code in PR #21147:
URL: https://github.com/apache/flink/pull/21147#discussion_r1020951099
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -1150,26 +1150,14 @@ private ApplicationReport startAppMaster(
final ContainerLaunchContext amContainer =
setupApplicationMasterContainer(yarnClusterEntrypoint,
hasKrb5, processSpec);
- // New delegation token framework
if
(configuration.getBoolean(SecurityOptions.KERBEROS_FETCH_DELEGATION_TOKEN)) {
- setTokensFor(amContainer);
- }
- // Old delegation token framework
- if (UserGroupInformation.isSecurityEnabled()) {
- LOG.info("Adding delegation token to the AM container.");
- final List<Path> pathsToObtainToken = new ArrayList<>();
- boolean fetchToken =
-
configuration.getBoolean(SecurityOptions.KERBEROS_FETCH_DELEGATION_TOKEN);
- if (fetchToken) {
- List<Path> yarnAccessList =
- ConfigUtils.decodeListFromConfig(
- configuration,
-
SecurityOptions.KERBEROS_HADOOP_FILESYSTEMS_TO_ACCESS,
- Path::new);
- pathsToObtainToken.addAll(yarnAccessList);
- pathsToObtainToken.addAll(fileUploader.getRemotePaths());
+ KerberosLoginProvider kerberosLoginProvider = new
KerberosLoginProvider(configuration);
+ if (kerberosLoginProvider.isLoginPossible()) {
+ setTokensFor(amContainer);
+ } else {
+ LOG.info(
+ "Cannot use kerberos delegation token manager no valid
kerberos credentials provided.");
Review Comment:
nit: token manager`,` no valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
