SteNicholas commented on code in PR #378:
URL: https://github.com/apache/flink-table-store/pull/378#discussion_r1021177345
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaManager.java:
##########
@@ -201,6 +203,12 @@ public TableSchema commitChanges(List<SchemaChange>
changes) throws Exception {
DataType newType =
TableSchema.toDataType(
update.newLogicalType(), new
AtomicInteger(0));
+ checkState(
Review Comment:
The behavior which check the implicit cast could move before line 202.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
