[ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529636#comment-15529636 ]
ASF GitHub Bot commented on FLINK-4562: --------------------------------------- Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2460#discussion_r80910964 --- Diff: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/StreamSQLExample.scala --- @@ -15,7 +15,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.flink.examples.scala +package org.apache.flink.table.examples --- End diff -- This should be called `org.apache.flink.table.examples.scala` to be consistent with `org.apache.flink.table.examples.java`. IMHO the language should be right after the `table`: `org.apache.flink.table.java.examples` > table examples make an divided module in flink-examples > ------------------------------------------------------- > > Key: FLINK-4562 > URL: https://issues.apache.org/jira/browse/FLINK-4562 > Project: Flink > Issue Type: Improvement > Reporter: shijinkui > > example code should't packaged in table module. -- This message was sent by Atlassian JIRA (v6.3.4#6332)